Remove Feature Flag Service in favor of OpenFeature + flagd #1388

austinlparker · 2024-02-18T21:31:47Z

Changes

This PR removes the Erlang featureflag service and its dependencies in favor of OpenFeature ecosystem projects.

Rationale

Feature Flag Service is a bit of a heavy dependency for the project to maintain. We don't have any regular Erlang contributors in maintainer/approver ranks, which makes it difficult to evaluate changes. There's been a fairly long-standing issue with cross-platform builds in QEMU and various Erlang components which has kept the service on outdated versions of OTP. We've had several feature requests for more flexibility around the feature flags that require setting via API, and the lack of a dedicated client for the feature flag service itself makes it somewhat challenging for contributors to add new things (as they have to write handlers for each application).

OpenFeature is a CNCF incubating project that's under active development and provides several things:

Client libraries for most languages
Lightweight flag daemon (flagd)
Kubernetes integration
Native OpenTelemetry support

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

CHANGELOG.md updated to document new feature additions
Appropriate documentation updates in the docs
Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

julianocosta89 · 2024-02-19T09:08:25Z

Wow!
This is a huge change but I'd hold it for a bit.
I wouldn't replace the FeatureFlagService without having another Erlang/Elixir service on the demo.

austinlparker · 2024-02-19T15:57:49Z

Wow! This is a huge change but I'd hold it for a bit. I wouldn't replace the FeatureFlagService without having another Erlang/Elixir service on the demo.

See #1343 (comment) -- I think we'll need to get another Erlang service added in as a stub off Kafka somehow. I don't necessarily think it should block this PR, though.

julianocosta89 · 2024-02-19T16:52:24Z

Wow! This is a huge change but I'd hold it for a bit. I wouldn't replace the FeatureFlagService without having another Erlang/Elixir service on the demo.

See #1343 (comment) -- I think we'll need to get another Erlang service added in as a stub off Kafka somehow. I don't necessarily think it should block this PR, though.

So you would drop Erlang/Elixir from the demo till we get a new service rewritten?

julianocosta89 · 2024-02-19T16:52:52Z

I vote against it.

austinlparker · 2024-02-19T16:54:52Z

We can discuss it at the next SIG meeting. I don't anticipate releasing the demo without an Erlang service, but we also can't arbitrarily hold off on integrating new changes because of implicit dependencies.

tsloughter · 2024-02-19T17:33:32Z

Wish I'd known about this I'd have done what I could to make it not necessary, I wasn't aware it was being considered. Does Erlang/Elixir now get no demo app?

austinlparker · 2024-02-19T17:35:34Z

Wish I'd known about this I'd have done what I could to make it not necessary, I wasn't aware it was being considered. Does Erlang/Elixir now get no demo app?

No, we'll still have an Erlang demo app, but probably a smaller one that's less of a maintenance burden?

tsloughter · 2024-02-19T17:42:23Z

So I can try to help, what burdern does it ease to be another service? You mention the build pipeline, how would that be different for product service or the new kafka service?

austinlparker · 2024-02-19T17:45:27Z

@tsloughter moving this convo over to #1343

beeme1mr · 2024-02-20T20:02:54Z

Hey @austinlparker, I'm one of the maintainers of OpenFeature. Thanks for getting this started! Please let me know if you have any questions.

agardnerIT · 2024-02-20T22:53:30Z

I'd have done what I could to make it not necessary

For the future, calls to the OpenFeature SDK can specify a default value so even if the backend is unavailable, you'll still get a working app.

austinlparker · 2024-02-20T22:55:16Z

I'd have done what I could to make it not necessary

For the future, calls to the OpenFeature SDK can specify a default value so even if the backend is unavailable, you'll still get a working app.

Feel free to check my work but I'm pretty sure that's what I've done here.

austinlparker · 2024-02-20T22:55:43Z

Hey @austinlparker, I'm one of the maintainers of OpenFeature. Thanks for getting this started! Please let me know if you have any questions.

Rad! Could you look into getting the python flagd provider released? :)

beeme1mr · 2024-02-21T21:25:22Z

Rad! Could you look into getting the python flagd provider released? :)

@thisthat has opened a PR. Hopefully, we can get publishing working tomorrow.

open-feature/python-sdk-contrib#38

austinlparker · 2024-02-21T22:06:57Z

Perfect!

tsloughter · 2024-02-27T14:49:46Z

@basti1302 nice, thanks, wish it would have worked out. I would fight this if it wasn't for the QEMU issue on M1+ -- and now I think at this point it is too far along to be worth finding out if the issue is resolved in OTP-27-rc.

beeme1mr

Looks good from an OpenFeature perspective. Once this has been merged, I could help set up the OpenTelemetry hooks, which provide span events and metrics based on the OTel semantic convention. We could also add client-side feature flags if there are any use cases you would like to support.

Thanks for your effort on this. @dyladan and I have a session at KubeCon talking about OpenTelemetry and OpenFeature. It would be amazing to use the OTel demo app for our examples.

src/adservice/src/main/java/oteldemo/AdService.java

src/flagd/demo.flagd.json

mviitane · 2024-02-28T15:48:42Z

When running this branch, I constantly get this error:
frontend | Error: 12 UNIMPLEMENTED: Method not found: oteldemo.AdService/GetAds
Anyone else see this?

julianocosta89 · 2024-03-04T08:23:20Z

@mviitane yes!

Error: 12 UNIMPLEMENTED: Method not found: oteldemo.AdService/GetAds
    at callErrorFromStatus (/app/node_modules/@grpc/grpc-js/build/src/call.js:31:19)
    at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client.js:192:76)
    at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:360:141)
    at Object.onReceiveStatus (/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:323:181)
    at /app/node_modules/@grpc/grpc-js/build/src/resolving-call.js:99:78
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)
for call at
    at ServiceClientImpl.makeUnaryRequest (/app/node_modules/@grpc/grpc-js/build/src/client.js:160:32)
    at ServiceClientImpl.<anonymous> (/app/node_modules/@grpc/grpc-js/build/src/make-client.js:105:19)
    at /app/node_modules/@opentelemetry/instrumentation-grpc/build/src/grpc-js/clientUtils.js:131:31
    at /app/node_modules/@opentelemetry/instrumentation-grpc/build/src/grpc-js/index.js:233:209
    at AsyncLocalStorage.run (node:async_hooks:338:14)
    at AsyncLocalStorageContextManager.with (/app/node_modules/@opentelemetry/context-async-hooks/build/src/AsyncLocalStorageContextManager.js:33:40)
    at ContextAPI.with (/app/node_modules/@opentelemetry/api/build/src/api/context.js:60:46)
    at ServiceClientImpl.clientMethodTrace [as getAds] (/app/node_modules/@opentelemetry/instrumentation-grpc/build/src/grpc-js/index.js:233:42)
    at /app/.next/server/pages/api/data.js:63:58
    at new Promise (<anonymous>) {
  code: 12,
  details: 'Method not found: oteldemo.AdService/GetAds',
  metadata: Metadata {
    internalRepr: Map(1) { 'content-type' => [Array] },
    options: {}
  }
}

@austinlparker was that working on the initial PR?

julianocosta89 · 2024-03-04T08:24:48Z

Ads are not being loaded at all:

austinlparker · 2024-03-04T21:01:24Z

Huh. I thought it was?

austinlparker · 2024-03-04T21:47:09Z

Hm, does seem like it's not working. The ad service is running fine though.

austinlparker · 2024-03-04T22:09:02Z

Should be working now, my bad.

austinlparker · 2024-03-06T14:33:07Z

@beeme1mr looks like the python otel hook isn't published yet?

austinlparker · 2024-03-06T16:55:01Z

See #1436 for notes on how we will integrate with k8s

julianocosta89

Tested it, and everything seems to be working fine.
Let's ship it! 🚀

beeme1mr · 2024-03-07T15:30:18Z

@beeme1mr looks like the python otel hook isn't published yet?

We'll publish the hook and include it in a follow up PR.

federicobond · 2024-03-14T05:42:34Z

@austinlparker the Python OTel hook is now released! Note that you need to update the import paths for the released version

https://pypi.org/project/openfeature-hooks-opentelemetry/

julianocosta89 · 2024-03-15T12:03:43Z

@federicobond I've tried adding it, but it seems there is an issue with the hook.
I've opened an issue here: open-feature/python-sdk-contrib#67

replace featureflag service with flagd

a87872e

github-actions bot requested review from jack-berg, mateuszrzeszutek and trask February 18, 2024 21:32

austinlparker mentioned this pull request Feb 18, 2024

Investigate replacing feature flag service #1343

Closed

austinlparker added 2 commits February 18, 2024 16:42

remove ff from gha

d533938

update changelog

c30d793

austinlparker marked this pull request as ready for review February 19, 2024 00:40

austinlparker requested a review from a team February 19, 2024 00:40

austinlparker added 3 commits February 18, 2024 19:40

fix sanity checker

4d77b4b

add python

b5fb5e2

fix sanity

1ea0441

This was referenced Feb 19, 2024

Feature Flag Service doesn't start when built from repository | server file "missing" #882

Closed

Toggle Feature Flags via Helm #1304

Closed

Merge branch 'main' into flagd-spike

b503f31

Merge branch 'main' into flagd-spike

c462cda

beeme1mr approved these changes Feb 27, 2024

View reviewed changes

src/adservice/src/main/java/oteldemo/AdService.java Show resolved Hide resolved

src/flagd/demo.flagd.json Outdated Show resolved Hide resolved

basti1302 mentioned this pull request Mar 1, 2024

[ON HOLD] [dash0] local deployment: remove custom ffs postgres again dash0hq/opentelemetry-demo#18

Draft

Merge branch 'main' into flagd-spike

24c82cf

fix adservice

ff19083

austinlparker and others added 6 commits March 4, 2024 16:11

Merge branch 'main' into flagd-spike

52b35bf

fixup gomod

d70b823

add otel hooks for .net flags

75533ab

add otel hooks for productcatalog

2f8861e

Remove trailing space

8430bbf

add stub for python otel hook

87618d3

austinlparker added 2 commits March 6, 2024 10:35

remove unneeded key from flags

dc6d2db

Merge branch 'main' into flagd-spike

334fe69

julianocosta89 approved these changes Mar 7, 2024

View reviewed changes

austinlparker merged commit ce4ad93 into open-telemetry:main Mar 7, 2024
26 checks passed

julianocosta89 mentioned this pull request Mar 13, 2024

[demo] Remove FeatureFlagService and add flagd open-telemetry/opentelemetry-helm-charts#1082

Merged

julianocosta89 mentioned this pull request Mar 15, 2024

http://localhost:8080/feature/ Page NOT FOUND #1459

Closed

jack-berg mentioned this pull request Mar 25, 2024

Adservice returns error status code when feature flag is enabled #1484

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove Feature Flag Service in favor of OpenFeature + flagd #1388

Remove Feature Flag Service in favor of OpenFeature + flagd #1388

austinlparker commented Feb 18, 2024 •

edited

Loading

julianocosta89 commented Feb 19, 2024

austinlparker commented Feb 19, 2024

julianocosta89 commented Feb 19, 2024

julianocosta89 commented Feb 19, 2024

austinlparker commented Feb 19, 2024

tsloughter commented Feb 19, 2024

austinlparker commented Feb 19, 2024

tsloughter commented Feb 19, 2024

austinlparker commented Feb 19, 2024

beeme1mr commented Feb 20, 2024

agardnerIT commented Feb 20, 2024

austinlparker commented Feb 20, 2024

austinlparker commented Feb 20, 2024

beeme1mr commented Feb 21, 2024

austinlparker commented Feb 21, 2024

tsloughter commented Feb 27, 2024

beeme1mr left a comment

mviitane commented Feb 28, 2024

julianocosta89 commented Mar 4, 2024

julianocosta89 commented Mar 4, 2024

austinlparker commented Mar 4, 2024

austinlparker commented Mar 4, 2024

austinlparker commented Mar 4, 2024

austinlparker commented Mar 6, 2024

austinlparker commented Mar 6, 2024

julianocosta89 left a comment

beeme1mr commented Mar 7, 2024

federicobond commented Mar 14, 2024 •

edited

Loading

julianocosta89 commented Mar 15, 2024

Remove Feature Flag Service in favor of OpenFeature + flagd #1388

Remove Feature Flag Service in favor of OpenFeature + flagd #1388

Conversation

austinlparker commented Feb 18, 2024 • edited Loading

Changes

Rationale

Merge Requirements

julianocosta89 commented Feb 19, 2024

austinlparker commented Feb 19, 2024

julianocosta89 commented Feb 19, 2024

julianocosta89 commented Feb 19, 2024

austinlparker commented Feb 19, 2024

tsloughter commented Feb 19, 2024

austinlparker commented Feb 19, 2024

tsloughter commented Feb 19, 2024

austinlparker commented Feb 19, 2024

beeme1mr commented Feb 20, 2024

agardnerIT commented Feb 20, 2024

austinlparker commented Feb 20, 2024

austinlparker commented Feb 20, 2024

beeme1mr commented Feb 21, 2024

austinlparker commented Feb 21, 2024

tsloughter commented Feb 27, 2024

beeme1mr left a comment

Choose a reason for hiding this comment

mviitane commented Feb 28, 2024

julianocosta89 commented Mar 4, 2024

julianocosta89 commented Mar 4, 2024

austinlparker commented Mar 4, 2024

austinlparker commented Mar 4, 2024

austinlparker commented Mar 4, 2024

austinlparker commented Mar 6, 2024

austinlparker commented Mar 6, 2024

julianocosta89 left a comment

Choose a reason for hiding this comment

beeme1mr commented Mar 7, 2024

federicobond commented Mar 14, 2024 • edited Loading

julianocosta89 commented Mar 15, 2024

austinlparker commented Feb 18, 2024 •

edited

Loading

federicobond commented Mar 14, 2024 •

edited

Loading